Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cextras: update to new main #297

Merged
merged 1 commit into from
Sep 6, 2024
Merged

cextras: update to new main #297

merged 1 commit into from
Sep 6, 2024

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Sep 6, 2024

This update fixes a malbehaviour on 32bit systems, where the cextras library would calculate the wrong size for array resizing.

The corresponding commit in cextras is 2777280db867664211f072fc4bd6173a781ec8d4.

 			return -CX_ERR_INTEGER_OVERFLOW;
 		}
 		// Set the bit at the position of the first 0 to 1
-		*val = 1ULL << (sizeof(size_t) * 8 - leading_zeros);
+		*val = 1ULL << (sizeof(long long) * 8 - leading_zeros); } return 0; }

Gottox/cextras@2777280

This update fixes a malbehaviour on 32bit systems, where the cextras
library would calculate the wrong size for array resizing.

The corresponding commit in cextras is 2777280db867664211f072fc4bd6173a781ec8d4.

	 			return -CX_ERR_INTEGER_OVERFLOW;
	 		}
	 		// Set the bit at the position of the first 0 to 1
	-		*val = 1ULL << (sizeof(size_t) * 8 - leading_zeros);
	+		*val = 1ULL << (sizeof(long long) * 8 - leading_zeros);
	 	}
	 	return 0;
	 }

Gottox/cextras@2777280
Copy link

sonarcloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.08%. Comparing base (a2c1f41) to head (d460410).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files          75       75           
  Lines        5898     5898           
  Branches      903      903           
=======================================
  Hits         3780     3780           
  Misses       1580     1580           
  Partials      538      538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox merged commit b53e227 into main Sep 6, 2024
18 checks passed
@Gottox Gottox deleted the fix/32bit-fail branch September 6, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant